Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle both intel & ARM RPM key #34

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Handle both intel & ARM RPM key #34

merged 6 commits into from
Jan 5, 2024

Conversation

paddyroddy
Copy link
Member

No description provided.

@paddyroddy paddyroddy self-assigned this Jan 4, 2024
@@ -14,7 +14,7 @@
- name: Import postgresql rpm key
ansible.builtin.rpm_key:
state: present
key: "{{ postgresql_rpm_gpg_key_pgdg }}"
key: "{{ postgresql_rpm_gpg_key_pgdg[ansible_architecture] }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| `postgresql_use_ssl` | Whether to use SSL |
| Name | Description |
| ------------------------------------ | ------------------------------------------------------------------- |
| `postgresql_rpm_gpg_key_pgdg_x86_64` | URL from which to download the RPM GPP key; not needed for CentOS 7 |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, there are two... Do we need to document both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

@paddyroddy
Copy link
Member Author

Tests now passing

@paddyroddy paddyroddy requested a review from p-j-smith January 5, 2024 10:21
Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@p-j-smith p-j-smith merged commit 0f44e39 into main Jan 5, 2024
5 checks passed
@p-j-smith p-j-smith deleted the arm branch January 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants